router.go (2)

310-310: Add a space after '//' in the comment for proper formatting

The comment at line 310 should have a space after the // for better readability and to adhere to Go's style guidelines.

Apply this diff to fix the comment formatting:

-//Decrement global handler count
+// Decrement global handler count

🧰 Tools

🪛 golangci-lint (1.62.2)

310-310: File is not gofumpt-ed with -extra

(gofumpt)

---

310-310: commentFormatting: put a space between // and comment text

(gocritic)

---

392-395: Simplify the return statement by directly returning the boolean expression

You can simplify the code by returning the result of the condition directly, which improves readability.

Apply this diff to simplify the code:

 if r.path == pathRaw {
     return true
 }
 return false
+// Simplify the return statement
+return r.path == pathRaw

🧰 Tools

🪛 golangci-lint (1.62.2)

392-392: S1008: should use 'return r.path == pathRaw' instead of 'if r.path == pathRaw { return true }; return false'

(gosimple)

router_test.go (5)

403-403: Remove unnecessary blank line at the start of the block

There is an extra empty line at the start of the block, which is unnecessary and can be removed for better code readability.

Apply this diff to remove the unnecessary line:

-	
 	app.Get("/test", func(c Ctx) error {

🧰 Tools

🪛 golangci-lint (1.62.2)

[warning] 403-403: empty-lines: extra empty line at the start of a block

(revive)

---

403-403: unnecessary leading newline

(whitespace)

---

414-414: Remove unnecessary blank line at the start of the block

There is an extra empty line at the start of the second route registration block, which can be removed for consistency and readability.

Apply this diff:

-	
 	app.Get("/test", func(c Ctx) error {

🧰 Tools

🪛 golangci-lint (1.62.2)

[warning] 414-414: empty-lines: extra empty line at the start of a block

(revive)

---

414-414: unnecessary leading newline

(whitespace)

---

471-471: Remove unnecessary blank line at the start of the block

An extra empty line is present at the start of the Test_App_Remove_Route_With_Middleware function block. Removing it improves code consistency.

Apply this diff:

-	
 func Test_App_Remove_Route_With_Middleware(t *testing.T) {

---

479-479: Remove unnecessary blank line inside the function

There's an extra blank line inside the function which can be removed to improve code readability.

Apply this diff:

-
 	app.Get("/test", func(c Ctx) error {

🧰 Tools

🪛 golangci-lint (1.62.2)

[warning] 479-479: empty-lines: extra empty line at the start of a block

(revive)

---

479-479: unnecessary leading newline

(whitespace)

---

490-490: Remove unnecessary blank line at the start of the block

Another extra empty line is present before the second route registration. Removing it maintains consistency.

Apply this diff:

-
 	app.Get("/test", func(c Ctx) error {

🧰 Tools

🪛 golangci-lint (1.62.2)

[warning] 490-490: empty-lines: extra empty line at the start of a block

(revive)

---

490-490: unnecessary leading newline

(whitespace)

Configuration used: CodeRabbit UI
Review profile: CHILL

router.go (3)

310-310: Add space after // in comment

Fix the comment formatting to follow Go conventions.

-			//Decrement global handler count
+			// Decrement global handler count

🧰 Tools

🪛 golangci-lint (1.62.2)

310-310: commentFormatting: put a space between // and comment text

(gocritic)

---

310-310: File is not gofumpt-ed with -extra

(gofumpt)

---

392-399: Simplify the return statement

The if-return block can be simplified to a direct return statement.

 func (app *App) routeExists(method string, pathRaw string) bool {
 	return slices.ContainsFunc(app.stack[app.methodInt(method)], func(r *Route) bool {
-		if r.path == pathRaw {
-			return true
-		}
-		return false
+		return r.path == pathRaw
 	})
 }

🧰 Tools

🪛 golangci-lint (1.62.2)

392-392: File is not gofumpt-ed with -extra

(gofumpt)

---

394-394: S1008: should use 'return r.path == pathRaw' instead of 'if r.path == pathRaw { return true }; return false'

(gosimple)

---

402-403: Remove or address TODO comments in documentation

The TODO comments in the documentation raise important questions about the intended usage of RemoveRoute. These should be either:

1. Removed if they're implementation notes
2. Converted to proper documentation if they're usage constraints

Configuration used: CodeRabbit UI
Review profile: CHILL

#!/bin/bash
# Check for mounted routes and middleware chains
ast-grep --pattern 'mount := true' -l go
rg -A 5 'func.*Mount'

# Check for potential memory leaks
rg -g '*.go' 'removeRoute|RemoveRoute' -A 5 -B 5

router_test.go (1)

457-514: Enhance middleware testing coverage

The test could be improved by:

1. Verifying middleware execution order
2. Testing multiple middleware functions
3. Testing middleware state preservation

 func Test_App_Remove_Route_With_Middleware(t *testing.T) {
     t.Parallel()
     app := New()
 
+    executionOrder := []string{}
     middleware1 := func(c Ctx) error {
+        executionOrder = append(executionOrder, "middleware1")
         return c.Next()
     }
+    middleware2 := func(c Ctx) error {
+        executionOrder = append(executionOrder, "middleware2")
+        return c.Next()
+    }
 
-    app.Get("/test", func(c Ctx) error {
-        // ... existing code ...
-    }, middleware1)
+    app.Get("/test", func(c Ctx) error {
+        executionOrder = append(executionOrder, "handler")
+        return c.SendStatus(http.StatusOK)
+    }, middleware1, middleware2)
 
     // ... rest of the test ...
+    require.Equal(t, []string{"middleware1", "middleware2", "handler"}, executionOrder)

🧰 Tools

🪛 golangci-lint (1.62.2)

[warning] 465-465: empty-lines: extra empty line at the start of a block

(revive)

---

465-465: unnecessary leading newline

(whitespace)

---

466-466: File is not gofumpt-ed with -extra

(gofumpt)

---

[warning] 476-476: empty-lines: extra empty line at the start of a block

(revive)

---

476-476: unnecessary leading newline

(whitespace)

---

477-477: File is not gofumpt-ed with -extra

(gofumpt)

Configuration used: CodeRabbit UI
Review profile: CHILL

router.go (2)

306-318: Clarify TODO comment and document handler count adjustment

The TODO comment about RemoveRoute needs clarification. Additionally, the handler count adjustment logic using bitwise complement (^) is not immediately obvious.

1. Remove or clarify the TODO comment
2. Add a comment explaining the handler count adjustment:

-            //Decrement global handler count
+            // Decrement global handler count using bitwise complement
+            // ^uint32(len(handlers)-1) is equivalent to -uint32(len(handlers)-1)
             atomic.AddUint32(&app.handlersCount, ^uint32(len(handlers)-1))

🧰 Tools

🪛 golangci-lint (1.62.2)

311-311: commentFormatting: put a space between // and comment text

(gocritic)

---

311-311: File is not gofumpt-ed with -extra

(gofumpt)

---

408-432: Improve error handling for invalid methods

The method silently skips invalid HTTP methods. Consider providing feedback to callers about invalid methods.

 func (app *App) deleteRoute(path string, methods []string) {
+    var invalidMethods []string
     for _, method := range methods {
         method = utils.ToUpper(method)
         m := app.methodInt(method)
         if m == -1 {
+            invalidMethods = append(invalidMethods, method)
             continue
         }
         index := slices.IndexFunc(app.stack[m], func(r *Route) bool {
             return r.Path == path
         })
         if index == -1 {
             continue
         }
         app.stack[m] = slices.Delete(app.stack[m], index, index+1)
     }
+    if len(invalidMethods) > 0 {
+        app.config.ErrorHandler(nil, fmt.Errorf("invalid HTTP methods: %v", invalidMethods))
+    }
     app.routesRefreshed = true
 }

router_test.go (2)

465-489: Enhance error messages in route handler verification

While the verification is thorough, the error message could be more descriptive.

 for _, route := range routes {
-    require.Equal(tb, 1, strings.Count(route.handlers, " "))
+    require.Equal(tb, 1, strings.Count(route.handlers, " "),
+        "route %s %s should have exactly one handler, got: %s",
+        route.method, route.path, route.handlers)
 }

🧰 Tools

🪛 golangci-lint (1.62.2)

[warning] 470-470: empty-lines: extra empty line at the start of a block

(revive)

---

470-470: unnecessary leading newline

(whitespace)

---

471-471: File is not gofumpt-ed with -extra

(gofumpt)

---

386-410: Add test cases for edge scenarios

While the basic functionality is well-tested, consider adding test cases for:

1. Removing non-existent routes
2. Removing routes with invalid methods
3. Concurrent route operations

Example test case:

func Test_App_Remove_NonExistent_Route(t *testing.T) {
    t.Parallel()
    app := New()
    
    app.RemoveRoute("/non-existent", "GET")
    require.Equal(t, uint32(0), app.handlersCount)
    require.Equal(t, uint32(0), app.routesCount)
}

Configuration used: CodeRabbit UI
Review profile: CHILL

router.go (4)

392-396: Improve RemoveRoute documentation

The method documentation should:

1. Explain the purpose of the middlewareCount parameter
2. Document the behavior when methods array is empty
3. Clarify when RebuildTree is required to be called

-// RemoveRoute is used to remove a route from the stack
-// You should call RebuildTree after using this to ensure consistency of the tree
+// RemoveRoute removes a route from the stack for the specified HTTP methods.
+// Parameters:
+//   - path: The route path to remove
+//   - middlewareCount: Number of middleware handlers (use 0 for routes without middleware)
+//   - methods: HTTP methods (GET, POST, etc.). If empty, the route is not removed
+//
+// Note: Call RebuildTree() after removing routes to ensure routing tree consistency

---

402-404: Clarify middleware count increment logic

The increment of middlewareCount when it's 0 is not clearly explained and could be confusing.

-	if middlewareCount == 0 {
-		middlewareCount++
-	}
+	// Ensure at least one handler is counted (the route handler itself)
+	if middlewareCount == 0 {
+		middlewareCount = 1 // Count the route handler
+	}

---

406-407: Simplify atomic decrement operation

The current atomic decrement using bitwise complement is hard to understand.

-	atomic.AddUint32(&app.handlersCount, ^uint32(middlewareCount-1))
+	atomic.AddUint32(&app.handlersCount, ^uint32(middlewareCount-1)) // Decrement by middlewareCount

🧰 Tools

🪛 golangci-lint (1.62.2)

406-406: commentFormatting: put a space between // and comment text

(gocritic)

---

406-406: File is not gofumpt-ed with -extra

(gofumpt)

---

416-418: Log invalid HTTP methods

The method silently skips invalid HTTP methods, which could hide configuration errors.

 		if m == -1 {
+			app.config.Logger.Printf("Invalid HTTP method %s when removing route %s", method, path)
 			continue // Skip invalid HTTP methods
 		}

router_test.go (2)

403-457: Consider using table-driven tests

The duplicate route registration tests have similar structure and could be refactored into a table-driven test to improve maintainability.

func Test_App_Route_Registration_Prevent_Duplicate(t *testing.T) {
    tests := []struct {
        name            string
        middleware     []func(Ctx) error
        expectedHandlers uint32
    }{
        {
            name:             "without middleware",
            middleware:       nil,
            expectedHandlers: 2,
        },
        {
            name:             "with middleware",
            middleware:       []func(Ctx) error{func(c Ctx) error { return c.Next() }},
            expectedHandlers: 3,
        },
    }
    
    for _, tt := range tests {
        t.Run(tt.name, func(t *testing.T) {
            app := New()
            registerTreeManipulationRoutes(app, tt.middleware...)
            registerTreeManipulationRoutes(app)
            
            verifyRequest(t, app, "/test", http.StatusOK)
            require.Equal(t, tt.expectedHandlers, app.handlersCount)
        })
    }
}

---

Line range hint 459-471: Remove unnecessary empty lines

The function has unnecessary empty lines at the start and end.

 func registerTreeManipulationRoutes(app *App, middleware ...func(Ctx) error) {
-
 	app.Get("/test", func(c Ctx) error {
 		app.Get("/dynamically-defined", func(c Ctx) error {
 			return c.SendStatus(http.StatusOK)
 		})
 		app.RebuildTree()
 		return c.SendStatus(http.StatusOK)
 	}, middleware...)
-
 }

🧰 Tools

🪛 golangci-lint (1.62.2)

470-470: File is not gofumpt-ed with -extra

(gofumpt)

---

471-471: unnecessary trailing newline

(whitespace)

---

[warning] 488-488: empty-lines: extra empty line at the start of a block

(revive)

---

488-488: unnecessary leading newline

(whitespace)

---

489-489: File is not gofumpt-ed with -extra

(gofumpt)

Configuration used: CodeRabbit UI
Review profile: CHILL

router_test.go (3)

380-380: Remove unnecessary empty lines in registerTreeManipulationRoutes

There are extra empty lines at the start and end of the registerTreeManipulationRoutes function, as flagged by the static analysis tool.

Apply this diff to remove the unnecessary empty lines:

-func registerTreeManipulationRoutes(app *App, middleware ...func(Ctx) error) {

+func registerTreeManipulationRoutes(app *App, middleware ...func(Ctx) error) {
    app.Get("/test", func(c Ctx) error {
        app.Get("/dynamically-defined", sendStatusOK)
        app.RebuildTree()
        return c.SendStatus(http.StatusOK)
    }, middleware...)
- 
}

Also applies to: 389-390

🧰 Tools

🪛 golangci-lint (1.62.2)

[warning] 380-380: empty-lines: extra empty line at the end of a block

(revive)

---

[warning] 380-380: empty-lines: extra empty line at the start of a block

(revive)

---

380-380: unnecessary leading newline

(whitespace)

---

407-408: Remove extra empty line in verifyRouteHandlerCounts

An unnecessary empty line is present at the start of the for loop in the verifyRouteHandlerCounts function.

Apply this diff to remove the empty line:

func verifyRouteHandlerCounts(tb testing.TB, app *App, expectedRoutesCount int) {
	tb.Helper()

-	//  this is taken from listen.go's printRoutesMessage app method
+	//  this is taken from listen.go's printRoutesMessage app method
	var routes []RouteMessage
	for _, routeStack := range app.stack {
		for _, route := range routeStack {
			// ...

🧰 Tools

🪛 golangci-lint (1.62.2)

[warning] 407-407: empty-lines: extra empty line at the start of a block

(revive)

---

407-407: unnecessary leading newline

(whitespace)

---

408-408: File is not gofumpt-ed with -extra

(gofumpt)

---

483-483: Remove unnecessary empty line at the end of function

There's an extra empty line at the end of Test_App_Remove_Route_Parameterized, which is unnecessary.

Apply this diff to remove the empty line:

func Test_App_Remove_Route_Parameterized(t *testing.T) {
	t.Parallel()
	app := New()

	app.Get("/test/:id", sendStatusOK)
	app.RemoveRoute("/test/:id", http.MethodGet)

	verifyThereAreNoRoutes(t, app)

-}
+}

🧰 Tools

🪛 golangci-lint (1.62.2)

[warning] 483-483: empty-lines: extra empty line at the end of a block

(revive)

router.go (3)

441-441: Add space after // in comment

The comment //Decrement global handler count lacks a space after //. Proper comment formatting improves code readability.

Apply this diff to fix the comment:

-//Decrement global handler count
+// Decrement global handler count
 atomic.AddUint32(&app.handlersCount, ^uint32(handlerCount-1)) //nolint:gosec // Not a concern

🧰 Tools

🪛 golangci-lint (1.62.2)

441-441: File is not gofumpt-ed with -extra

(gofumpt)

---

441-441: commentFormatting: put a space between // and comment text

(gocritic)

---

442-442: Correct the nolint directive formatting

The nolint directive should immediately follow // without a leading space to be properly recognized by linters.

Apply this diff to correct the formatting:

 atomic.AddUint32(&app.handlersCount, ^uint32(handlerCount-1)) // nolint:gosec // Not a concern
-atomic.AddUint32(&app.handlersCount, ^uint32(handlerCount-1)) // nolint:gosec // Not a concern
+atomic.AddUint32(&app.handlersCount, ^uint32(handlerCount-1)) //nolint:gosec // Not a concern

🧰 Tools

🪛 golangci-lint (1.62.2)

442-442: directive // nolint:gosec // Not a concern should be written without leading space as //nolint:gosec // Not a concern

(nolintlint)

---

386-400: Address gofumpt formatting issues in routeExists

The routeExists function is not formatted according to gofumpt -extra guidelines, as indicated by the static analysis tool. Consistent formatting improves code readability and maintainability.

Consider running gofumpt -extra on the file to apply standard formatting.

🧰 Tools

🪛 golangci-lint (1.62.2)

386-386: File is not gofumpt-ed with -extra

(gofumpt)

Configuration used: CodeRabbit UI
Review profile: CHILL

#!/bin/bash
# Description: Verify that the Go version is 1.21 or higher

# Extract the Go version from go.mod
go_version=$(grep '^go ' go.mod | awk '{print $2}')

# Compare versions
required_version="1.21"

if [[ "$(printf '%s\n' "$required_version" "$go_version" | sort -V | head -n1)" == "$required_version" ]]; then
  echo "Go version ($go_version) is compatible."
else
  echo "Go version ($go_version) is not compatible. Please update to Go 1.21 or higher."
fi

router.go (3)

306-312: Consider adding debug logging for route replacement

The duplicate route handling logic is correct, but it would be helpful to log when a route is being replaced to aid in debugging and monitoring.

 // Duplicate Route Handling
 if app.routeExists(method, pathRaw) {
+    if app.config.EnableDebugLog {
+        app.debug("[Router] Replacing existing route: %s %s", method, pathRaw)
+    }
     matchPathFunc := func(r *Route) bool { return r.Path == pathRaw }
     app.deleteRoute([]string{method}, matchPathFunc)
 }

---

402-408: Clarify documentation about duplicate prevention

The comment "This only needs to be called to remove a route, route registration prevents duplicate routes" might be confusing. Consider clarifying that while registration prevents duplicates by replacing existing routes, this method is needed for explicit route removal.

-// This only needs to be called to remove a route, route registration prevents duplicate routes.
+// This method is used to explicitly remove a route. Note that registering a route with an existing path
+// will automatically replace the old route, but this method allows removing routes without replacement.

---

418-450: Consider documenting atomic operations

The atomic operations for decrementing counters use bitwise complement, which might not be immediately obvious to all developers.

 // Decrement global handler count
-atomic.AddUint32(&app.handlersCount, ^uint32(len(route.Handlers)-1)) // nolint:gosec // Not a concern
+// Use bitwise complement (^) with AddUint32 to perform atomic decrement
+atomic.AddUint32(&app.handlersCount, ^uint32(len(route.Handlers)-1))
 // Decrement global route position
-atomic.AddUint32(&app.routesCount, ^uint32(0))
+// Decrement route count by 1 using bitwise complement of 0
+atomic.AddUint32(&app.routesCount, ^uint32(0))

🧰 Tools

🪛 golangci-lint (1.62.2)

441-441: directive // nolint:gosec // Not a concern should be written without leading space as //nolint:gosec // Not a concern

(nolintlint)

router_test.go (1)

520-597: Consider adding more concurrent test scenarios

While the concurrent test is good, consider adding tests for:

1. Concurrent removal of different routes
2. Concurrent operations on routes with middleware
3. Concurrent operations with route groups

Example additional test:

func Test_App_Remove_Route_Concurrent_Different_Routes(t *testing.T) {
    t.Parallel()
    app := New()
    
    // Add test routes
    app.Get("/test1", sendStatusOK)
    app.Get("/test2", sendStatusOK)
    
    // Concurrently remove different routes
    var wg sync.WaitGroup
    wg.Add(2)
    go func() {
        defer wg.Done()
        app.RemoveRoute("/test1", http.MethodGet)
    }()
    go func() {
        defer wg.Done()
        app.RemoveRoute("/test2", http.MethodGet)
    }()
    wg.Wait()
    
    app.RebuildTree()
    verifyThereAreNoRoutes(t, app)
}

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Dockerfile (1)

1-19: Add final stage for smaller runtime image.

While the builder stage is well-configured, consider adding a final stage for a smaller runtime image.

Add this after the current content:

+# Create small runtime image
+FROM scratch
+
+COPY --from=builder /app/server /server
+
+EXPOSE 3000
+ENTRYPOINT ["/server"]

router_test.go (2)

380-390: Fix formatting issues.

The function is well-structured but has unnecessary empty lines.

Apply this diff to fix formatting:

 func registerTreeManipulationRoutes(app *App, middleware ...func(Ctx) error) {
-
     app.Get("/test", func(c Ctx) error {
         app.Get("/dynamically-defined", sendStatusOK)
-
         app.RebuildTree()
-
         return c.SendStatus(http.StatusOK)
     }, middleware...)
-
 }

🧰 Tools

🪛 golangci-lint (1.62.2)

[warning] 380-380: empty-lines: extra empty line at the start of a block

(revive)

---

[warning] 380-380: empty-lines: extra empty line at the end of a block

(revive)

---

380-380: unnecessary leading newline

(whitespace)

---

381-381: File is not gofumpt-ed with -extra

(gofumpt)

---

389-389: File is not gofumpt-ed with -extra

(gofumpt)

---

390-390: unnecessary trailing newline

(whitespace)

---

402-427: Consider simplifying route message collection.

While the function works correctly, it could be simplified for better maintainability.

Consider this refactoring:

 func verifyRouteHandlerCounts(tb testing.TB, app *App, expectedRoutesCount int) {
     tb.Helper()
 
-    var routes []RouteMessage
+    routes := make(map[string]RouteMessage)
     for _, routeStack := range app.stack {
         for _, route := range routeStack {
             routeMsg := RouteMessage{
                 name:   route.Name,
                 method: route.Method,
                 path:   route.Path,
             }
 
             for _, handler := range route.Handlers {
                 routeMsg.handlers += runtime.FuncForPC(reflect.ValueOf(handler).Pointer()).Name() + " "
             }
 
-            routes = append(routes, routeMsg)
+            key := route.Method + route.Path
+            routes[key] = routeMsg
         }
     }
 
-    for _, route := range routes {
+    for _, route := range routes {
         require.Equal(tb, expectedRoutesCount, strings.Count(route.handlers, " "))
     }
 }

🧰 Tools

🪛 golangci-lint (1.62.2)

[warning] 407-407: empty-lines: extra empty line at the start of a block

(revive)

---

407-407: unnecessary leading newline

(whitespace)

---

408-408: File is not gofumpt-ed with -extra

(gofumpt)

docs/whats_new.md (1)

944-951: Add usage examples for route removal features.

The documentation would benefit from examples showing:

1. Basic route removal
2. Route removal by name
3. Rebuilding the tree after removal

Consider adding examples like:

// Remove route by path
app.RemoveRoute("/api/users", MethodGet)
app.RebuildTree()

// Remove route by name
app.Get("/api/users", handler).Name("users")
app.RemoveRouteByName("users", MethodGet)
app.RebuildTree()

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

#!/bin/bash
# Search for request handling code that might be affected by concurrent route removal
rg -A 5 "func.*next.*" router.go

#!/bin/bash
# Check how treeStack is populated and if there's any synchronization
rg -A 10 "treeStack.*=" router.go

# Look for tree building/refreshing logic
ast-grep --pattern 'func (app *App) buildTree() {
  $$$
}'

# Check if there's any read locking during request handling
rg -B 2 -A 5 "mutex\.(RLock|Lock)" router.go

#!/bin/bash
# Check the main request handling logic
rg -B 5 -A 10 "func.*Handler|func.*handle" router.go

# Look for any tree access synchronization in the context
ast-grep --pattern 'func (c *$_) $_($$$) {
  $$$
  app.treeStack
  $$$
}'

Dockerfile (2)

1-20: Consider moving Dockerfile to documentation.

Based on the previous discussion, this Dockerfile was created for local development on Windows. Since it's a development tool, it would be more appropriate to move it to the documentation or another Fiber repository.

---

45-46: Fix formatting in RUN command.

Add whitespace after the RUN command for better readability.

-RUN --mount=type=cache,target=/go/pkg/mod/cache
-    go mod download -x
+RUN --mount=type=cache,target=/go/pkg/mod/cache \
+    go mod download -x

🧰 Tools

🪛 Hadolint (2.12.0)

[error] 45-45: missing whitespace

(DL1000)

docs/api/app.md (1)

768-768: Fix spacing in documentation.

Remove the extra space at the beginning of the sentence.

-This method removes a route by path.  You must call the `RebuildTree()` method after the remove in to ensure the route is removed.
+This method removes a route by path. You must call the `RebuildTree()` method after the remove in to ensure the route is removed.

router_test.go (3)

376-390: Fix formatting issues.

The code has unnecessary empty lines and formatting issues.

Apply this diff to fix the formatting:

 func sendStatusOK(c Ctx) error {
     return c.SendStatus(http.StatusOK)
 }
-
 func registerTreeManipulationRoutes(app *App, middleware ...func(Ctx) error) {
-
     app.Get("/test", func(c Ctx) error {
         app.Get("/dynamically-defined", sendStatusOK)
-
         app.RebuildTree()
-
         return c.SendStatus(http.StatusOK)
     }, middleware...)
-
 }

🧰 Tools

🪛 golangci-lint (1.62.2)

[warning] 380-380: empty-lines: extra empty line at the end of a block

(revive)

---

[warning] 380-380: empty-lines: extra empty line at the start of a block

(revive)

---

380-380: unnecessary leading newline

(whitespace)

---

381-381: File is not gofumpt-ed with -extra

(gofumpt)

---

389-389: File is not gofumpt-ed with -extra

(gofumpt)

---

390-390: unnecessary trailing newline

(whitespace)

---

525-535: Fix formatting issues.

The test has unnecessary empty lines.

Apply this diff to fix the formatting:

 func Test_App_Remove_Route_Parameterized(t *testing.T) {
     t.Parallel()
     app := New()

     app.Get("/test/:id", sendStatusOK)
     verifyRequest(t, app, "/test/:id", http.StatusOK)
     app.RemoveRoute("/test/:id", MethodGet)

     verifyThereAreNoRoutes(t, app)
-
 }

🧰 Tools

🪛 golangci-lint (1.62.2)

[warning] 525-525: empty-lines: extra empty line at the end of a block

(revive)

---

534-534: File is not gofumpt-ed with -extra

(gofumpt)

---

535-535: unnecessary trailing newline

(whitespace)

---

559-581: Consider enhancing concurrent test verification.

While the test verifies basic concurrent operations, consider adding:

1. Verification of intermediate states
2. Checking for race conditions using the race detector
3. Verifying handler counts remain consistent

Apply this diff to enhance the test:

 func Test_App_Remove_Route_Concurrent(t *testing.T) {
     t.Parallel()
     app := New()

     // Add test route
     app.Get("/test", sendStatusOK)
+    initialHandlersCount := app.handlersCount

     // Concurrently remove and add routes
     var wg sync.WaitGroup
     for i := 0; i < 10; i++ {
         wg.Add(1)
         go func() {
             defer wg.Done()
             app.RemoveRoute("/test", MethodGet)
             app.Get("/test", sendStatusOK)
         }()
     }
     wg.Wait()

     // Verify final state
     app.RebuildTree()
     verifyRequest(t, app, "/test", http.StatusOK)
+    require.Equal(t, initialHandlersCount, app.handlersCount, "Handlers count should remain consistent")
+    verifyRouteHandlerCounts(t, app, 1)
 }

To run with race detector:

go test -race ./... -run=Test_App_Remove_Route_Concurrent